Screenshot app #31
Merged
Screenshot app #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
eriklangille
requested review from
efeberkeevci
and removed request for
SkylarLJY
efeberkeevci
reviewed
Feb 9, 2022
| {"function_name": "formplug-dev-receive", "folder_name": "formplug", "last_log_timestamp": 1644018632028, "vendor": "AWS", "DB_URL": "localhost", "DB_PORT": 27017, "workload_path": "spot/benchmarks/AWSHelloWorld/workload.json", "region": "us-east-2", "mem_size": 128, "workload": {"test_name": "IntegrationTest1", "test_duration_in_seconds": 15, "random_seed": 100, "blocking_cli": false, "instances": {"instance1": {"application": "formplug-dev-receive", "distribution": "Poisson", "rate": 5, "activity_window": [5, 10], "payload": "spot/benchmarks/formplug/payload.json", "host": "psihxi4hxi.execute-api.us-east-2.amazonaws.com", "stage": "dev", "resource": "?format=json"}}}} |
There was a problem hiding this comment.
This is incorrect. Why does the path of formplug config include AWSHelloWorld(or old version HelloWorld in the first place)?
There was a problem hiding this comment.
That came from a typo in one of my commits, should be the name of the corresponding benchmark folder.
There was a problem hiding this comment.
@eriklangille Can you change accordingly?
| @@ -0,0 +1,93 @@ | |||
| !_TAG_FILE_FORMAT 2 /extended format; --format=1 will not append ;" to lines/ | |||
There was a problem hiding this comment.
Can you add a short description of what this document is for
There was a problem hiding this comment.
This should have not been committed
|
Was there a license for this benchmark? Yaman's benchmark has one and while revieiwing his PR, I thought you should add the license if it exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headless chrome that takes a screenshot of a page and provides the screenshot as the result working with SPOT
Closes #15