Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs fields are saved as int or float instead of text #59

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

eriklangille
Copy link
Contributor

In the MongoDB database, save the log files as int and float instead of text. This is useful for querying the collections

Copy link
Contributor

@efeberkeevci efeberkeevci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the way we should save the data. Thanks for making the type changes. Have you checked if other components fail with this changes?

@eriklangille
Copy link
Contributor Author

eriklangille commented Mar 23, 2022

This is the way we should save the data. Thanks for making the type changes. Have you checked if other components fail with this changes?

Hmm it appears that it currently doesn't work because sometimes the config document's "LastModifiedInMs" is saved as a string and sometimes saved as an int. Trying to figure out now why it varies... It fails for values saved as string

EDIT: Looks like there was a recent change in the code that now saves the config as an int where as before it was saved as a string. Just need to convert the old configs in the database

@eriklangille
Copy link
Contributor Author

Old configs and logs have been converted in the database now

@eriklangille eriklangille merged commit 9890c2d into master Mar 24, 2022
@eriklangille eriklangille deleted the log_numbers branch April 22, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants