SPOT suggesting non-minimal configs and fixed log retriever #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eriklangille
commented
Mar 31, 2022
eriklangille
commented
- Log retriever will fetch more than 50 logs
- Jupyter notebook for data exploration
- All requests saved to collection and deleted when matching request log fetched
- More context to graph; added memory recommendation and fixed polynomial (now displays constant term)
SkylarLJY
reviewed
Mar 31, 2022
| status = res["StatusCode"] | ||
| error = False | ||
| if status < 200 or status >= 300: | ||
| print(f"WARNING: Status code {status} for request id {req_id}") |
There was a problem hiding this comment.
What about using the logging module for warnings
| @@ -43,6 +43,10 @@ def __init__( | |||
|
|
|||
| def _preprocess(self): | |||
| self._df[MEM_SIZE] = self._df[MEM_SIZE].astype(int) | |||
| self._df = self._df[ | |||
There was a problem hiding this comment.
This is quite important addition!
Yeah that part of the code hasn't been properly implemented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.