Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributions added #66

Merged
merged 2 commits into from
Apr 22, 2022
Merged

attributions added #66

merged 2 commits into from
Apr 22, 2022

Conversation

yamanmalkoc
Copy link
Contributor

No description provided.

Copy link
Contributor

@jpzg jpzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also put their copyright info in the included license files (where there are placeholders in brackets).

@jpzg
Copy link
Contributor

jpzg commented Apr 15, 2022

Also: This would close #46.

@jpzg
Copy link
Contributor

jpzg commented Apr 22, 2022

On second thought - those placeholders are actually not part of the license, they're in the instructions for how to apply the license to your work:

APPENDIX: How to apply the Apache License to your work.

  To apply the Apache License to your work, attach the following
  boilerplate notice, with the fields enclosed by brackets "[]"
  replaced with your own identifying information.

It's probably not our right or responsibility to add that notice where they did not. So, LGTM.

@jpzg jpzg merged commit 0eb835e into master Apr 22, 2022
@jpzg jpzg deleted the licensing branch April 22, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants