This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Streamline i18n tooling and added French Canadian, German as well as Japanese #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @xcompass @richardtape, Could you please take a look at this pull request? Thank you! |
|
@AhmedAljazzar and @melvinsoft, could one of you please also take a quick look here? |
kitsook
reviewed
Aug 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been adding standard-ish i18n tooling for various popular Open edX XBlocks e.g. poll xblock and Google Drive. The end-goal is to make the i18n workflow as seamless as possible.
The UBCPI XBlock already has most of the required tooling (thank you), so I'll be adding only few additional commands.
New Additions
pull_translations,push_translationsalso amendedtestto ensure proper file translations.Bonus
I also have plans to make a i18n bot that updates the translations to save on engineering hours.