Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local: use go1.13 UserConfigDir for InertiaDir #618

Merged
merged 6 commits into from
Sep 12, 2019

Conversation

bobheadxi
Copy link
Member

@bobheadxi bobheadxi commented Sep 12, 2019

🎟️ Ticket(s): for #611


👷 Changes

  • use the new UserConfigDir in the standard library to put global Inertia config in
  • inertia remote config-path to show where stuff is going
  • minor update to contributing docs to reflect changes

🔦 Testing Instructions

❯ ./inertia init --global
global Inertia configuration intialized at /Users/robertlin/Library/Application Support/inertia/inertia.global
❯ ./inertia remote config-path                                                   
global configuration directory: '/Users/robertlin/Library/Application Support/inertia'
global configuration path:      '/Users/robertlin/Library/Application Support/inertia/inertia.global'

@bobheadxi bobheadxi added the pr: finalized needs review and final approval label Sep 12, 2019
@bobheadxi bobheadxi requested a review from a team September 12, 2019 02:54
@bobheadxi bobheadxi changed the title local: use go1.13 UserConfigDir for InertiDir local: use go1.13 UserConfigDir for InertiaDir Sep 12, 2019
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   55.88%   55.88%           
=======================================
  Files          68       68           
  Lines        3377     3377           
=======================================
  Hits         1887     1887           
  Misses       1248     1248           
  Partials      242      242
Impacted Files Coverage Δ
local/storage.go 26.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9211e8...ad635a9. Read the comment docs.

@bobheadxi bobheadxi mentioned this pull request Sep 12, 2019
3 tasks
@bobheadxi bobheadxi merged commit 498cab5 into master Sep 12, 2019
@bobheadxi bobheadxi deleted the local/#611-go-113-config-dir branch September 12, 2019 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: finalized needs review and final approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant