add a metrics to indicate store replication job run (#286)

uber-archive · Sep 1, 2017 · 9790e57 · 9790e57
1 parent 08d5bef
commit 9790e57
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/common/metrics/defs.go b/common/metrics/defs.go
@@ -955,6 +955,8 @@ const (
 	StorageReplicationJobCurrentFailures
 	// StorageReplicationJobCurrentSuccess is the number of success job in current run
 	StorageReplicationJobCurrentSuccess
+	// StorageReplicationJobRun indicates the replication job runs
+	StorageReplicationJobRun
 
 	// -- Controller metrics -- //
 
@@ -1236,6 +1238,7 @@ var metricDefs = map[ServiceIdx]map[int]metricDefinition{
 		StorageReplicationJobMaxConsecutiveFailures: {Gauge, "storage.replication-job.max-consecutive-failures"},
 		StorageReplicationJobCurrentFailures:        {Gauge, "storage.replication-job.current-failures"},
 		StorageReplicationJobCurrentSuccess:         {Gauge, "storage.replication-job.current-success"},
+		StorageReplicationJobRun:                    {Gauge, "storage.replication-job.run"},
 	},
 
 	// definitions for Controller metrics

diff --git a/services/storehost/replicationJobRunner.go b/services/storehost/replicationJobRunner.go
@@ -267,6 +267,7 @@ func (runner *replicationJobRunner) run() {
 	runner.m3Client.UpdateGauge(metrics.ReplicateExtentScope, metrics.StorageReplicationJobCurrentFailures, int64(len(currentFailedJobs)))
 	runner.m3Client.UpdateGauge(metrics.ReplicateExtentScope, metrics.StorageReplicationJobMaxConsecutiveFailures, int64(maxConsecutiveFailures))
 	runner.m3Client.UpdateGauge(metrics.ReplicateExtentScope, metrics.StorageReplicationJobCurrentSuccess, int64(jobsStarted))
+	runner.m3Client.UpdateGauge(metrics.ReplicateExtentScope, metrics.StorageReplicationJobRun, 1)
 
 	runner.logger.WithFields(bark.Fields{
 		`stats`: fmt.Sprintf(`total extents: %v, remote extents:%v, opened for replication: %v, primary: %v, secondary: %v, failed: %v, success: %v`,