This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
DeleteDestination does not apply TTL on some fields #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirg
pushed a commit
that referenced
this pull request
May 13, 2017
* DeleteDestination does not apply TTL on some fields * remove debug printf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the metadata changes for KFC, we added two new columns to the destinations table, 'kafka_topics' and 'kafka_cluster'; but we forgot to apply the TTL to these two columns in the DeleteDestination sql query.
For the fix, I have updated the queries to ensure the insert and delete code-paths use very similar queries, except for the additional TTL parameter for delete.