This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Include destination path in CreateDestination resource URN #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 529ed63 on createdst_urn into ** on master**. |
|
Changes Unknown when pulling a455bca on createdst_urn into ** on master**. |
datoug
approved these changes
May 16, 2017
common/auth_util.go
Outdated
| } | ||
|
|
||
| parts := strings.Split(*path, "/") | ||
| if len(parts) == 0 { |
There was a problem hiding this comment.
I don't think this condition will ever be satisfied. Even for empty string, len(parts) will be 1
There was a problem hiding this comment.
You are right :) Let me change the code a little bit.
|
Changes Unknown when pulling a2122d9 on createdst_urn into ** on master**. |
|
Changes Unknown when pulling 3b8bad6 on createdst_urn into ** on master**. |
|
Changes Unknown when pulling 3b8bad6 on createdst_urn into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.