This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
fix sirupsen repo name #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 0eb11de on g into ** on master**. |
hiboyang
approved these changes
Jun 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is straightforward except ringpop.
We locked ringpop at v0.7.0 as there's some breaking change with later releases(not breaking interface, but functionality wise breaking, as there're some test failure if we bring in latest ringpop).
Because of that, we also locked github.com/uber-common/bark to commit 8841a0f8e7ca869284ccb29c08a14cf3f4310f46 since ringpop v0.7.0 is not compatible with the latest bark interface.
As a temporary solution(without introducing the latest ringpop, which might cause functionality issue), I created hotfix branches on top of the version we locked down: fix-logrus-8841a0f and v0.7.0.fix.sirupsen for these two branches.
Opened #225 to track the progress to upgrade to latest ringpop and bark.