This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add auth check for DeleteConsumerGroup; Add permissions for owner #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 20, 2017 16:50
datoug
approved these changes
Jun 21, 2017
services/frontendhost/frontend.go
Outdated
| lclLg) | ||
| // Add Read/Update/Delete permissions for the current user and owner on the destination | ||
| subjects := []common.Subject{authSubject} | ||
| if createRequest.OwnerEmail != nil && *createRequest.OwnerEmail != "" { |
There was a problem hiding this comment.
you can just do a len(createRequest.GetOwnerEmail()) > 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add auth check for DeleteConsumerGroup
Add permissions for owner of Destination/Consumer Group to Read/Update/Delete