This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Add UpdateHostsForDeployment API to replicatorClientFactory so that replicator host is updatable #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should implement zookeeper server for host updater |
datoug
force-pushed
the
replicator_host_updater
branch
2 times, most recently
from
783d638 to
dd6d35a
Compare
datoug
changed the title
thuningxu
reviewed
Jul 18, 2017
| @@ -42,3 +47,14 @@ func (r *ReplicatorConfig) GetReplicatorHosts() map[string]string { | |||
| func (r *ReplicatorConfig) GetDefaultAuthoritativeZone() string { | |||
| return r.DefaultAuthoritativeZone | |||
| } | |||
|
|
|||
| // GetUseStandalone checks whether a specific deployment is using standalone deployment | |||
| func (r *ReplicatorConfig) GetUseStandalone(deployment string) bool { | |||
There was a problem hiding this comment.
I feel this is irrelevant to open source users.
There was a problem hiding this comment.
Yea, open source is not using this config. Right now we don't have a clean way to have 'internal only' config(interface is defined in open source) so keep it here for now.
thuningxu
reviewed
Jul 18, 2017
| h, tc := replicator.NewReplicator(serviceName, sCommon, meta, replicator.NewReplicatorClientFactory(cfg, common.GetDefaultLogger()), cfg) | ||
| allHosts := cfg.GetReplicatorConfig().GetReplicatorHosts() | ||
| allSplitHosts := make(map[string][]string) | ||
| for deployment, hosts := range allHosts { |
There was a problem hiding this comment.
I almost feel GetReplicatorHosts() should include this logic and return map[string][]string. Thoughts?
There was a problem hiding this comment.
These logic is more like a util function rather than some logic that is specific to replicator, so I slightly feel better to keep it outside.
thuningxu
approved these changes
Jul 18, 2017
datoug
force-pushed
the
replicator_host_updater
branch
from
73e9736 to
958fd58
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.