Import atomic package #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM except license headers are messed up |
| /vendor | ||
| /cover | ||
| cover.out | ||
|
|
There was a problem hiding this comment.
Can we also include the standard GitHub .gitignore for Go? https://github.com/github/gitignore/blob/master/Go.gitignore
There was a problem hiding this comment.
I feel like some of those are a little overkill (object files? we're not compiling C!)
I'll add the useful ones from there though (*.prof, *.test)
|
Obviously, actual code looks spectacularly amazing :) Nits aside, lgtm. |
prashantv
force-pushed
the
import
branch
3 times, most recently
from
e033f98 to
ad79209
Compare
|
Removed update license scripts (WIP, fixing them separately). I ran the wip script to update the licenses properly though. |
The code is the same as github.com/uber/tchannel-go/atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is the same as github.com/uber/tchannel-go/atomic
cc @akshayjshah