Implement String method for pointers #122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 23 +1
Lines 231 232 +1
=========================================
+ Hits 231 232 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pointer_go119.go
Outdated
| // String returns a human readable representation of a Pointer's underlying value. | ||
| func (p *Pointer[T]) String() string { | ||
| return fmt.Sprint(p.p.Load()) | ||
| } |
There was a problem hiding this comment.
So, the way we're using build tags here is a bit non-standard.
We have a separate 1.18 and 1.19 file, where 1.18 has nothing shared with 1.19.
With build tags, "go1.18" is actually enabled for all Go versions starting 1.18.
(Which is why we have a "!go1.19" in the 1.18 file.)
I think what would be better to do here is sharing this String method between 1.18 and 1.19 somehow.
We need it to be defined in a file with the "go1.18" tag, but not the "!go1.19" tag.
So perhaps we can rename pointer_go118 to pointer_go118_pre119, making it clear that it's only for Go 1.18,
and create a new pointer_go118 file that only has the "go1.18" tag and this method.
That fill will compile for both, 1.18 and 1.19.
There was a problem hiding this comment.
Done!
This pointer to a pointer test case that's failing is a bit tricky though. I didn't notice it at first since the tests pass locally. Any suggestions? The test file is so clean as is, I don't want to overcomplicate it. I not sure if it's worth recursively loading in the case of pointers either.
josephinedotlee
force-pushed
the
jlee/pointer-string
branch
2 times, most recently
from
3700101
to
7d2f3ae
Compare
By implementing this method ourselves using atomic loading and fmt.Sprint, we can avoid possible unguarded accesses to the embedded pointer if someone attempts to fmt.Print the atomic.Pointer .
josephinedotlee
force-pushed
the
jlee/pointer-string
branch
from
7d2f3ae
to
2399d79
Compare
By implementing this method ourselves using atomic loading and fmt.Sprint, we can avoid possible unguarded accesses to the embedded pointer if someone attempts to fmt.Print the atomic.Pointer
.
Before opening your pull request, please make sure that you've:
make test); and finally,make lint).Thanks for your contribution!