go.uber.org/atomic => sync/atomic #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace uses of go.uber.org/atomic with the standard library's sync/atomic. On top of that, upgrade to the latest release of multierr to pull in uber-go/multierr#72 which made a similar change there. With these two changes combined, drop the dependency on go.uber.org/atomic completely.
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 87.20% 87.20%
=======================================
Files 32 32
Lines 2603 2603
=======================================
Hits 2270 2270
Misses 269 269
Partials 64 64
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of go.uber.org/atomic
with the standard library's sync/atomic.
On top of that, upgrade to the latest release of multierr
to pull in uber-go/multierr#72 which made a similar change there.
With these two changes combined,
drop the dependency on go.uber.org/atomic completely.
(Won't pass lint until #59 merges.)