Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Scope to Dig #305

Merged
merged 16 commits into from
Dec 22, 2021
Merged

Introduce Scope to Dig #305

merged 16 commits into from
Dec 22, 2021

Commits on Dec 6, 2021

  1. add dig.Scope

    @sywhang
    sywhang committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    339b30a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Merge remote-tracking branch 'upstream/master' into scope-1

    @sywhang
    sywhang committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    5988a24 View commit details
    Browse the repository at this point in the history

  2. tests are all passing

    @sywhang
    sywhang committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    06ffea5 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. add more tests, private provides and cross-Scope cycle checks fully f… 

    …unctional
    @sywhang
    sywhang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    df3e502 View commit details
    Browse the repository at this point in the history

  2. more tests

    @sywhang
    sywhang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    4d4df2f View commit details
    Browse the repository at this point in the history

  3. make linter happy

    @sywhang
    sywhang committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    374f584 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. avoid copying over providers,value,groups for creating child scope

    @sywhang
    sywhang committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    5dc219e View commit details
    Browse the repository at this point in the history

  2. each ctor gets provided exactly once; change err message to include s… 

    …cope name
    @sywhang
    sywhang committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    7e82f37 View commit details
    Browse the repository at this point in the history

  3. update comments

    @sywhang
    sywhang committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    b531800 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2021

  1. save/restore state for all Scopes affected

    @sywhang
    sywhang committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    050ec0c View commit details
    Browse the repository at this point in the history

  2. loop literal

    @sywhang
    sywhang committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    487391d View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. address code review feedback

    @sywhang
    sywhang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    cbf60a8 View commit details
    Browse the repository at this point in the history

  2. typo

    @sywhang
    sywhang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    0ba222a View commit details
    Browse the repository at this point in the history

  3. fix docstrings

    @sywhang
    sywhang committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    9c35896 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. address code review feedback

    @sywhang
    sywhang committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    2a86ead View commit details
    Browse the repository at this point in the history

  2. Add more permutations to scope test with DeferAcyclicVerification and… 

    … DryRun
    @sywhang
    sywhang committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    5b172dd View commit details
    Browse the repository at this point in the history