scope: Use an empty name for root #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Root scope should have an empty name, not a string like "container". Cycle error will skip the `[scope "foo"]` for the root container.
abhinav
force-pushed
the
abg/graph-simpler
branch
from
40a22ea
to
ccc076b
Compare
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 19 19
Lines 1234 1234
=======================================
Hits 1215 1215
Misses 11 11
Partials 8 8
Continue to review full report at Codecov.
|
sywhang
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original discussions for Scope, we said that the root scope
(
Container) will have an empty name, not "container".PR #305 introduced Scope with the default name "container".
Proposing this as a resolution to that pending discussion.