You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The same result could be achieved by installing the same version explicitly in make lint with go install golang.org/x/lint/golint@v0.0.0-20190930215403-16217165b5de, and the tools_test.go and go.mod reference could be dropped, to avoid propagating an unmaintained dependency into downstreams that use this library.
The text was updated successfully, but these errors were encountered:
Fixes#92.
Avoid tools dependencies in goleak's go.mod.
golint is deprecated, we can separately migrate to another tool, but the
tools change avoids any CI-time dependency from leaking into our go.mod.
The golang.org/x/lint library is marked as deprecated / unmaintained / readonly
This library takes an explicit dependency on it in https://github.com/uber-go/goleak/blob/master/tools_test.go in order to record a specific version of it in go.mod, for use with
go install
in themake lint
target.The same result could be achieved by installing the same version explicitly in
make lint
withgo install golang.org/x/lint/golint@v0.0.0-20190930215403-16217165b5de
, and the tools_test.go and go.mod reference could be dropped, to avoid propagating an unmaintained dependency into downstreams that use this library.The text was updated successfully, but these errors were encountered: