Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document incompatibility of VerifyNone with t.Parallel #107

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Document incompatibility of VerifyNone with t.Parallel #107

merged 2 commits into from
Oct 12, 2023

Commits on Oct 12, 2023

  1. Document incompatibility of VerifyNone with t.Parallel 

    It's a known issue that goleak is incompatible with tests being run in parallel.
* uber-go#16
* uber-go#83

Unfortunately, there is no real solution to this issue.
* uber-go#16 (comment)
* uber-go#83 (comment)
* uber-go#83 (comment)

This PR at least documents the incompatibility
and suggests using `VerifyTestMain` instead.
    @JacobOaks
    JacobOaks committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    aaa9a37 View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @JacobOaks
    JacobOaks committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7a1ce0a View commit details
    Browse the repository at this point in the history