-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack: Parse all functions #111
Merged
Merged
Commits on Oct 22, 2023
-
Adds support to the stack parser for reading the full list of functions for a stack trace. This includes the function that created the stack trace; it's the bottom of the stack. We don't maintain the order of the functions since that's not something we need at this time. The functions are all placed in a set.
Configuration menu - View commit details
-
Copy full SHA for b5b49ed - Browse repository at this point
Copy the full SHA b5b49edView commit details -
Support Go 1.20 "created by" lines
In Go 1.20, the "created by" lines do not include the "in goroutine" portion.
Configuration menu - View commit details
-
Copy full SHA for 9e226f2 - Browse repository at this point
Copy the full SHA 9e226f2View commit details -
fix: Don't remove file paths from full traces
`Full()` was accidentally dropping the file names from the full traces.
Configuration menu - View commit details
-
Copy full SHA for a649b8e - Browse repository at this point
Copy the full SHA a649b8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6173c18 - Browse repository at this point
Copy the full SHA 6173c18View commit details -
Configuration menu - View commit details
-
Copy full SHA for af394ca - Browse repository at this point
Copy the full SHA af394caView commit details -
stack: "created by" is not part of the stack
The function tha created a goroutine should not be considered part of its stack. However, we can use that entry to mark the end of a stack trace.
Configuration menu - View commit details
-
Copy full SHA for 7bdc274 - Browse repository at this point
Copy the full SHA 7bdc274View commit details -
To verify the stacktrace parsing logic, generate real stack traces under the following conditions: - Go 1.21 - Go 1.20 installed with gimme - Go 1.21 with tracebackancestors=10 set The test verifies that the parsed stack traces do not include functions that we did not expect to see in a goroutine's trace.
Configuration menu - View commit details
-
Copy full SHA for b4e7421 - Browse repository at this point
Copy the full SHA b4e7421View commit details
Commits on Oct 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5b4de07 - Browse repository at this point
Copy the full SHA 5b4de07View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.