Ignore t.Parallel goroutines, they represent queued tests #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When t.Parallel is used, tests are queued to run after all serially executed tests are run. This causes issues if the serial test tries to verify goroutines.
|
|
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 4 4
Lines 141 141
=======================================
Hits 134 134
Misses 4 4
Partials 3 3
Continue to review full report at Codecov.
|
Closed
chucknthem
approved these changes
Jun 5, 2018
options.go
Outdated
| @@ -115,7 +115,7 @@ func isTestStack(s stack.Stack) bool { | |||
| // to end by waiting on a channel. | |||
| // Since go1.7, a separate goroutine is started to wait for signals. | |||
| switch s.FirstFunction() { | |||
| case "testing.RunTests", "testing.(*T).Run": | |||
| case "testing.RunTests", "testing.(*T).Run", "testing.(*T).Parallel": | |||
| // In pre1.7 and post-1.7, background goroutines started by the testing | |||
There was a problem hiding this comment.
edit the comment to include t.Parallel
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When t.Parallel is used, tests are queued to run after all serially
executed tests are run. This causes issues if the serial test tries to
verify goroutines.
Fixes #16