Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore blocked trace stack by default #40

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Ignore blocked trace stack by default #40

merged 1 commit into from
Jan 7, 2020

Commits on Dec 20, 2019

  1. Ignore blocked trace stack by default

    When running tests with `-trace`, a background
    goroutine blocks on `runtime.ReadTrace`:
    ```
    Goroutine 20 in state trace reader (blocked), with runtime.goparkunlock on top of the stack:
    goroutine 20 [trace reader (blocked)]:
    runtime.goparkunlock(...)
    	(truncated)/go1.13.linux.amd64/src/runtime/proc.go:310
    runtime.ReadTrace(0xc00008e048, 0xc0000160d0, 0x10)
    	(truncated)/go1.13.linux.amd64/src/runtime/trace.go:395 +0x4ed
    runtime/trace.Start.func1(0x7b3dc0, 0xc00008e048)
    	(truncated)/go1.13.linux.amd64/src/runtime/trace/trace.go:129 +0x47
    created by runtime/trace.Start
    	(truncated)/go1.13.linux.amd64/src/runtime/trace/trace.go:127 +0xd8
    ```
    
    Skip this stack by default. Run tests with `-trace` enabled to verify
    that this stack should be skipped.
    
    Fixes #39.
    prashantv committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    5735272 View commit details
    Browse the repository at this point in the history