Don't Panic: Remove main panic #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our example, we `panic` in `main` instead of the function `foo`. The point that this was demonstrating was that the caller of the function has the choice of panicking rather than `foo` itself. Unfortunately, this causes confusion for readers modeling their `main()` after this code, because the "good" example still panics. This reduces confusion here by having `main` handle the `error` with an `os.Exit`. Note that this moves argument handling into `foo` because placing it in `main` is not very testable.
abhinav
force-pushed
the
abg/dont-panic
branch
from
9d5e149
to
d4b4568
Compare
|
Do you know where your towel is? (+42) |
mway
approved these changes
Sep 14, 2020
prashantv
approved these changes
Sep 14, 2020
mmelnyk
pushed a commit
to mmelnyk/guide
that referenced
this pull request
Oct 8, 2020
In our example, we `panic` in `main` instead of the function `foo`. The point that this was demonstrating was that the caller of the function has the choice of panicking rather than `foo` itself. Unfortunately, this causes confusion for readers modeling their `main()` after this code, because the "good" example still panics. This reduces confusion here by having `main` handle the `error` with an `os.Exit`. Note that this moves argument handling into `foo` because placing it in `main` is not very testable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our example, we
panicinmaininstead of the functionfoo. Thepoint that this was demonstrating was that the caller of the function
has the choice of panicking rather than
fooitself.Unfortunately, this causes confusion for readers modeling their
main()after this code, because the "good" example still panics.
This reduces confusion here by having
mainhandle theerrorwith anos.Exit.Note that this moves argument handling into
foobecause placing it inmainis not very testable.