Skip to content

Commit

Permalink
skip unexported methods
Browse files Browse the repository at this point in the history
  • Loading branch information
sywhang committed Oct 23, 2023
1 parent c045055 commit d619fd7
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions mockgen/model/model_gotypes.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ func InterfaceFromGoTypesType(it *types.Interface) (*Interface, error) {

for i := 0; i < it.NumMethods(); i++ {
mt := it.Method(i)
// TODO: need to skip unexported methods? or just raise an error?
// Skip unexported methods.
if !mt.Exported() {
continue
}
m := &Method{
Name: mt.Name(),
}
Expand All @@ -36,13 +39,15 @@ func funcArgsFromGoTypesType(t *types.Signature) (in []*Parameter, variadic *Par
}
var p *Parameter
for i := 0; i < nin; i++ {
if p, err = parameterFromGoTypesType(t.Params().At(i), false); err != nil {
p, err = parameterFromGoTypesType(t.Params().At(i), false)
if err != nil {
return
}
in = append(in, p)
}
if t.Variadic() {
if p, err = parameterFromGoTypesType(t.Params().At(nin), true); err != nil {
p, err = parameterFromGoTypesType(t.Params().At(nin), true)
if err != nil {
return
}
variadic = p
Expand Down Expand Up @@ -70,12 +75,6 @@ func parameterFromGoTypesType(v *types.Var, variadic bool) (*Parameter, error) {
}

func typeFromGoTypesType(t types.Type) (Type, error) {
// Hack workaround for https://golang.org/issue/3853.
// This explicit check should not be necessary.
// if t == byteType {
// return PredeclaredType("byte"), nil
// }

if t, ok := t.(*types.Named); ok {
tn := t.Obj()
if tn.Pkg() == nil {
Expand Down

0 comments on commit d619fd7

Please sign in to comment.