Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests on Windows #121

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

craig65535
Copy link
Contributor

To address #120

@r-hang
Copy link
Contributor

r-hang commented Nov 9, 2023

We should always be using forward slashes for package paths so the use of "path" which constrains to forwards slashes looks good to me.

ref: https://groups.google.com/g/Golang-nuts/c/bmKNJ1dkGiw/m/vgPCu6-5BAAJ

@r-hang r-hang merged commit 7fb6390 into uber-go:main Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants