CI: Test with Go 1.17 #1009
Merged
CI: Test with Go 1.17 #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Go 1.17 to the list of versions we test with. `gofmt` all files to add the new `//go:build` directives meant to replace `// +build`. This supersedes the Go version upgrade in #999. That PR will be narrowed down just to Windows support.
Codecov Report
@@ Coverage Diff @@
## master #1009 +/- ##
=======================================
Coverage 98.10% 98.10%
=======================================
Files 46 46
Lines 2058 2058
=======================================
Hits 2019 2019
Misses 30 30
Partials 9 9 Continue to review full report at Codecov.
|
rabbbit
reviewed
Sep 10, 2021
| @@ -19,6 +19,7 @@ | |||
| // THE SOFTWARE. | |||
|
|
|||
| // See #682 for more information. | |||
| //go:build go1.12 | |||
There was a problem hiding this comment.
can we just kill these now?
There was a problem hiding this comment.
Yeah we can probably kill the pre Go 1.12 files; I'll do that in a follow up.
moisesvega
approved these changes
Sep 10, 2021
rabbbit
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Go 1.17 to the list of versions we test with.
gofmtall files toadd the new
//go:builddirectives meant to replace// +build.This supersedes the Go version upgrade in #999. That PR will be narrowed
down just to Windows support.