Add Must(*Logger, error) *Logger function #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
- Coverage 98.36% 98.27% -0.10%
==========================================
Files 49 49
Lines 2142 2145 +3
==========================================
+ Hits 2107 2108 +1
- Misses 27 28 +1
- Partials 8 9 +1
Continue to review full report at Codecov.
|
mway
reviewed
Jun 3, 2022
| // var logger := zap.Must(zap.NewProduction()) | ||
| func Must(logger *Logger, err error) *Logger { | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
Thanks for the PR! Can you add a quick test to cover this branch, please?
There was a problem hiding this comment.
Test added in parallel. haha. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #640.