Fix make cover to include /exp packages
#1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `make cover` did not include coverage from exp/ packages because it was targeting only the root package. This fixes the command so that it can include sub modules. Before: ``` ❯ make cover go test -race -coverprofile=cover.out -coverpkg=./... ./... ? go.uber.org/zap/internal [no test files] ? go.uber.org/zap/internal/bufferpool [no test files] ? go.uber.org/zap/internal/readme [no test files] ok go.uber.org/zap 1.877s coverage: 99.5% of statements in ./... ok go.uber.org/zap/buffer 0.228s coverage: 89.7% of statements in ./... ok go.uber.org/zap/internal/color 0.353s coverage: 100.0% of statements in ./... ok go.uber.org/zap/internal/exit 0.424s coverage: 100.0% of statements in ./... ok go.uber.org/zap/internal/pool 0.506s coverage: 100.0% of statements in ./... ok go.uber.org/zap/internal/ztest 0.566s coverage: 15.4% of statements in ./... ok go.uber.org/zap/zapcore 2.958s coverage: 6.0% of statements in ./... ok go.uber.org/zap/zapgrpc 0.524s coverage: 8.2% of statements in ./... ok go.uber.org/zap/zapio 0.560s coverage: 5.8% of statements in ./... ok go.uber.org/zap/zaptest 0.710s coverage: 11.7% of statements in ./... ok go.uber.org/zap/zaptest/observer 0.463s coverage: 7.9% of statements in ./... go tool cover -html=cover.out -o cover.html ``` After: ``` ❯ make cover ? go.uber.org/zap/internal [no test files] ? go.uber.org/zap/internal/bufferpool [no test files] ? go.uber.org/zap/internal/readme [no test files] ok go.uber.org/zap 1.921s coverage: 99.5% of statements in ./... ok go.uber.org/zap/buffer 0.591s coverage: 89.7% of statements in ./... ok go.uber.org/zap/internal/color 0.396s coverage: 100.0% of statements in ./... ok go.uber.org/zap/internal/exit 0.677s coverage: 100.0% of statements in ./... ok go.uber.org/zap/internal/pool 0.929s coverage: 100.0% of statements in ./... ok go.uber.org/zap/internal/ztest 0.798s coverage: 15.4% of statements in ./... ok go.uber.org/zap/zapcore 3.273s coverage: 6.0% of statements in ./... ok go.uber.org/zap/zapgrpc 0.972s coverage: 8.2% of statements in ./... ok go.uber.org/zap/zapio 1.071s coverage: 5.8% of statements in ./... ok go.uber.org/zap/zaptest 1.204s coverage: 11.7% of statements in ./... ok go.uber.org/zap/zaptest/observer 0.887s coverage: 7.9% of statements in ./... ok go.uber.org/zap/exp/zapfield 0.206s coverage: 100.0% of statements in ./... ok go.uber.org/zap/exp/zapslog 0.396s coverage: 84.4% of statements in ./... ok go.uber.org/zap/benchmarks 0.197s coverage: [no statements] [no tests to run] ok go.uber.org/zap/zapgrpc/internal/test 0.213s coverage: [no statements] ```
Codecov Report
@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
- Coverage 97.93% 97.61% -0.33%
==========================================
Files 50 52 +2
Lines 3249 3355 +106
==========================================
+ Hits 3182 3275 +93
- Misses 57 69 +12
- Partials 10 11 +1 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rabbbit
reviewed
Aug 3, 2023
abhinav
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
make coverdid not include coverage from exp/ packages because it was targeting only the root package.This fixes the command so that it can include sub modules.
Before:
After: