zapslog: Delete x/exp-based implementation #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
+ Coverage 97.45% 97.77% +0.31%
==========================================
Files 52 51 -1
Lines 3463 3366 -97
==========================================
- Hits 3375 3291 -84
+ Misses 77 65 -12
+ Partials 11 10 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
abhinav
force-pushed
the
slog-rm-pre-120
branch
from
2652f05
to
40419bf
Compare
Deletes the implementation of slog.Handler based on golang.org/x/exp/slog. Maintaining two implementations doesn't serve much value here. Remaining files have been renamed to better match their contents: - handler.go holds the slog.Handler - handler_test.go tests that - example_test.go contains example tests Files that remain are still tagged with `go1.21` so they're only visible to Go 1.21 or newer. This way, `go test` in this directory with Go 1.20 will not fail: ``` % GOTOOLCHAIN=go1.20 go test -v ? go.uber.org/zap/exp/zapslog [no test files] ``` Resolves uber-go#1337
abhinav
force-pushed
the
slog-rm-pre-120
branch
from
40419bf
to
539b648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes the implementation of slog.Handler based on
golang.org/x/exp/slog.
Maintaining two implementations doesn't serve much value here.
Remaining files have been renamed to better match their contents:
Files that remain are still tagged with
go1.21so they're only visible to Go 1.21 or newer.
This way,
go testin this directory with Go 1.20 will not fail:Resolves #1337