Add func DictObject
#1460
Add func DictObject
#1460
Conversation
|
|
|
Thanks for the PR, @MayCXC. |
you got it, I added doc comments & tests. |
field.go
Outdated
| // DictObject exposes the [zapcore.ObjectMarshaler] for an array of [Field] to | ||
| // use with functions like [Object] and [Objects]. |
There was a problem hiding this comment.
I would reword this a bit. Object/Objects aren't the only uses of this.
| // DictObject exposes the [zapcore.ObjectMarshaler] for an array of [Field] to | |
| // use with functions like [Object] and [Objects]. | |
| // DictObject constructs a [zapcore.ObjectMarshaler] with the given list of fields. | |
| // The resulting object may be used as input to [Object], [Objects], | |
| // or anywhere else that an object is expected. |
There was a problem hiding this comment.
I reworded it a bit based on this feedback
| b: zap.Object("k", zap.DictObject(zap.String("a", "b"))), | ||
| want: true, | ||
| }, | ||
| { | ||
| a: zap.Object("k", zap.DictObject(zap.String("a", "b"))), |
There was a problem hiding this comment.
The example test is good, and this equality check makes sense.
Would you also mind adding a test similar to TestDict that asserts the shape of the resulting JSON-ey object.
There was a problem hiding this comment.
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
…yCXC/add-dictobject
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1460 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 53 53
Lines 3018 3020 +2
=======================================
+ Hits 2979 2981 +2
Misses 31 31
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Allows fields to be used to construct
ObjectMarshalers that can then be used with other functions likefunc Objects. Link to issue: #1458