Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make global loggers safe for concurrent use #316

Merged
merged 2 commits into from
Feb 21, 2017
Merged

Make global loggers safe for concurrent use #316

merged 2 commits into from
Feb 21, 2017

Commits on Feb 21, 2017

  1. Make global loggers safe for concurrent use 

    I'd originally intended zap's global loggers to be a consenting-adults sort of
API in which easily-avoided data races are okay. After just a few migrations,
it's become clear just how naive that plan was.

This PR adds tests to verify that the global loggers are safe to use and
reconfigure concurrently, and it converts the global variables to (short)
functions.
    Akshay Shah committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    3ba540d View commit details
    Browse the repository at this point in the history

  2. Last cleanups from CR

    Akshay Shah committed Feb 21, 2017
    Configuration menu
    Copy the full SHA
    1e69a29 View commit details
    Browse the repository at this point in the history