Export zap's internal observing logger #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashantv
approved these changes
Mar 14, 2017
| ) | ||
| infoLogger, _ := observer.New(InfoLevel) | ||
| warnLogger, _ := observer.New(WarnLevel) | ||
| tee := NewTee(infoLogger, warnLogger) |
There was a problem hiding this comment.
do we need real loggers here, can we pass NopLoggers or something?
There was a problem hiding this comment.
The NopCore is always disabled, so it's not helpful here.
zaptest/observer/observer.go
Outdated
| // error, but does so that it can be used as an observer sink function. | ||
| func (o *ObservedLogs) Add(log LoggedEntry) error { | ||
| // Add appends a new observed log to the collection. | ||
| func (o *ObservedLogs) Add(log LoggedEntry) { |
There was a problem hiding this comment.
does this need to be exported?
There was a problem hiding this comment.
Nope, I'll push a small change to un-export it.
akshayjshah
approved these changes
Mar 14, 2017
| "go.uber.org/zap/zaptest/observer" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
👍 Thanks for the import reordering.
| ) | ||
| infoLogger, _ := observer.New(InfoLevel) | ||
| warnLogger, _ := observer.New(WarnLevel) | ||
| tee := NewTee(infoLogger, warnLogger) |
There was a problem hiding this comment.
The NopCore is always disabled, so it's not helpful here.
zaptest/observer/observer.go
Outdated
| // error, but does so that it can be used as an observer sink function. | ||
| func (o *ObservedLogs) Add(log LoggedEntry) error { | ||
| // Add appends a new observed log to the collection. | ||
| func (o *ObservedLogs) Add(log LoggedEntry) { |
There was a problem hiding this comment.
Nope, I'll push a small change to un-export it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
internal/observerand export it aszaptest/observer.