Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix in windows file path can't support #624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix in windows file path can't support #624

wants to merge 1 commit into from

Conversation

wenzhihong2003
Copy link

fix bug #621

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wenzhihong2003 wenzhihong2003 mentioned this pull request Aug 20, 2018
Open
prashantv
prashantv reviewed Aug 23, 2018
View reviewed changes
Copy link
Collaborator

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but I'm not sure whether this is a necessary change. The issue seems to be that the path starts with a /, this is due to file:///c:/ rather than file://c:/.

@selslack
Copy link

@prashantv

Then it'll fail with error: can't parse "file://C:\\Users\\..." as a URL: parse file://C:\Use rs\...: invalid character "\\" in host name. See #621 (comment) as well as golang/go#13276.

Fix from #621 works fine.

@mniewrzal mniewrzal mentioned this pull request Sep 10, 2019
Merged
9 tasks
@AnnaShaleva AnnaShaleva mentioned this pull request Nov 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantv prashantv prashantv left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wenzhihong2003 @CLAassistant @selslack @prashantv