lint: Check that 'go mod tidy' was run #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #948, we noticed that some `go.sum` files were outdated. To avoid this in the future, add a `lint` check that verifies that `go mod tidy` does not cause any changes. This will fail with a dirty working tree as well, but in CI, we don't expect that.
Codecov Report
@@ Coverage Diff @@
## master #951 +/- ##
==========================================
- Coverage 98.12% 98.02% -0.11%
==========================================
Files 44 44
Lines 1975 1975
==========================================
- Hits 1938 1936 -2
- Misses 29 30 +1
- Partials 8 9 +1
Continue to review full report at Codecov.
|
moisesvega
approved these changes
May 25, 2021
abhinav
added a commit
that referenced
this pull request
May 25, 2021
In #948, we noticed that some `go.sum` files were outdated. To avoid this in the future, add a `lint` check that verifies that `go mod tidy` does not cause any changes. This will fail with a dirty working tree as well, but in CI, we don't expect that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #948, we noticed that some
go.sumfiles were outdated. To avoidthis in the future, add a
lintcheck that verifies thatgo mod tidydoes not cause any changes.
This will fail with a dirty working tree as well, but in CI, we don't
expect that.