Fix tests #103
Merged
Fix tests #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I found that yarn.lock was declared in .gitignore, meaning that the installation for this package's dependencies is currently not deterministic - I assume yarn is the intended package manager, considering that there are scripts in package.json that explicitly call out to it - I found that generating yarn.lock from a fresh checkout brings the project into a state where tests fail - I fixed the root cause of the failure (using relative path in some places, but using absolute paths in others) - I also increased jest timeout for some tests that were timing out for whatever reason
|
|
lhorie
commented
Jan 14, 2020
| `${includePrefix}${definition.id.name}.${ | ||
| enumDefinition.id.name | ||
| }` | ||
| `${includePrefix}${definition.id.name}.${enumDefinition.id.name}` |
There was a problem hiding this comment.
this change is the output of eslint --fix
lhorie
commented
Jan 14, 2020
| @@ -8,4 +8,3 @@ | |||
| .tmp | |||
|
|
|||
| yarn-error.log | |||
| yarn.lock | |||
There was a problem hiding this comment.
assuming yarn since a script in package.json calls out to it
lhorie
commented
Jan 14, 2020
| @@ -27,6 +27,8 @@ | |||
| import fs from 'fs'; | |||
| import {flowResultTest} from '../../test-util'; | |||
|
|
|||
| jest.setTimeout(10000); | |||
There was a problem hiding this comment.
don't know why some tests timeout, increasing value solves it
There was a problem hiding this comment.
Can we at least add a TODO or additional task to investigate why this is needed?
lhorie
commented
Jan 14, 2020
| @@ -98,7 +98,7 @@ export class ThriftFileConverter { | |||
|
|
|||
| constructor(thriftPath: string, withsource: boolean) { | |||
| this.thriftPath = path.resolve(thriftPath); | |||
| this.thrift = thrift({...thriftOptions, entryPoint: thriftPath}); | |||
| this.thrift = thrift({...thriftOptions, entryPoint: this.thriftPath}); | |||
There was a problem hiding this comment.
This fixes a test failure due to .definitions is undefined NPE
AlexMSmithCA
approved these changes
Jan 14, 2020
KevinGrandon
approved these changes
Jan 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint --fix