Support classes that are both Worker and RibCoroutineWorker in co…
#629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@psteiger You can also do a manual validation via sample app for this hybrid "worker"? It's located in here https://github.com/uber/RIBs/blob/main/android/demos/rib-workers/src/main/kotlin/com/uber/rib/workers/root/main/ribworkerselection/RibWorkerSelectionInteractor.kt |
FranAguilera
approved these changes
Dec 5, 2023
| @@ -315,3 +355,18 @@ private class TestWorker : RibCoroutineWorker { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private class WorkerAndRibCoroutineWorker( | |||
There was a problem hiding this comment.
Can we add a comment here regarding that this pattern is not recommended?
psteiger
force-pushed
the
rrw-converters-fix
branch
from
a57d276
to
0bdd7ce
Compare
…nverters.
`Worker.asRibCoroutineWorker` and `RibCoroutineWorker.asWorker` converters now return the instance unchanged if the class already implements the target interface.
This is important for correctness. For example:
```
class DualWorker : Worker, RibCoroutineWorker {
fun onStart(lifecycle: WorkerScopeProvider) {
doX()
}
suspend fun onStart(scope: CoroutineScope) {
doY()
}
}
```
Binding this `worker.asWorker()` should call `doX()`, not `doY()`, and binding this `worker.asRibCoroutineWorker()` should call `doY()`, not `doX()`.
psteiger
force-pushed
the
rrw-converters-fix
branch
from
0bdd7ce
to
3ca704a
Compare
tyvsmith
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nverters.
Worker.asRibCoroutineWorkerandRibCoroutineWorker.asWorkerconverters now return the instance unchanged if the class already implements the target interface.This is important for correctness. For example:
Binding this
worker.asWorker()should calldoX(), notdoY(), and binding thisworker.asRibCoroutineWorker()should calldoY(), notdoX().