Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass variables to the modules that don't declare them #40

Merged
merged 4 commits into from
Sep 19, 2019

Conversation

btromanova
Copy link
Contributor

This fixes issue #39.

Terraform 0.12 returns an error, if we try to pass a variable to the module that didn't declare it.

Looks like there was a bug in the logic of binding variables that user provided to the arguments defined in the config.

This PR fixes it and adds a test for it.

@btromanova btromanova requested a review from DragonZ August 13, 2019 07:06
@CLAassistant
Copy link

CLAassistant commented Aug 13, 2019

CLA assistant check
All committers have signed the CLA.

Copy link

@DragonZ DragonZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dansimau dansimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btromanova btromanova merged commit be238b2 into master Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants