Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BaseXClassifier bug #218

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Fix BaseXClassifier bug #218

merged 2 commits into from
Jul 21, 2020

Conversation

yungmsh
Copy link
Contributor

@yungmsh yungmsh commented Jul 21, 2020

Addresses this issue: #180

ppstacy
ppstacy approved these changes Jul 21, 2020
View reviewed changes
Copy link
Collaborator

@ppstacy ppstacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@yungmsh yungmsh merged commit cfa1289 into master Jul 21, 2020
huigangchen pushed a commit that referenced this pull request Jan 27, 2021
@yungmsh
Merge pull request #218 from uber/fix_xclassifier_bug
f14c290 
Fix BaseXClassifier bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppstacy ppstacy ppstacy approved these changes

@jeongyoonlee jeongyoonlee Awaiting requested review from jeongyoonlee

@paullo0106 paullo0106 Awaiting requested review from paullo0106

@yluogit yluogit Awaiting requested review from yluogit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yungmsh @ppstacy