Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making UTF-8 encoding explicit when reading README.md #232

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

ccrndn
Copy link
Contributor

@ccrndn ccrndn commented Sep 11, 2020

"pip install causalml" fails (decoding error) when the system encoding is not UTF8 (e.g ASCII).

Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-ccs_s93d/causalml/setup.py", line 17, in <module>
        long_description = f.read()
      File "/usr/lib64/python3.6/encodings/ascii.py", line 26, in decode
        return codecs.ascii_decode(input, self.errors)[0]
    UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 8370: ordinal not in range(128)

"pip install causalml" fails (decoding error) when the system encoding is not UTF8 (e.g ASCII).
@CLAassistant
Copy link

CLAassistant commented Sep 11, 2020

CLA assistant check
All committers have signed the CLA.

@ccrndn ccrndn changed the title Explicit UTF-8 encoding when reading README.md Making UTF-8 encoding explicit when reading README.md Sep 11, 2020
@jeongyoonlee
Copy link
Collaborator

Thanks for the contribution, @ccrndn! Could you please sign the Contributor License Agreement so that we can accept your contribution? Thanks!

Copy link
Collaborator

@jeongyoonlee jeongyoonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jeongyoonlee jeongyoonlee added the documentation Improvements or additions to documentation label Oct 7, 2020
@jeongyoonlee jeongyoonlee merged commit 3a2c4eb into uber:master Oct 7, 2020
@paullo0106 paullo0106 mentioned this pull request Oct 23, 2020
huigangchen pushed a commit that referenced this pull request Jan 27, 2021
"pip install causalml" fails (decoding error) when the system encoding is not UTF8 (e.g ASCII).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants