Update filters.py #281
Merged
Update filters.py #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smooth label count per treatment in _GetNodeSummary() by adding 1 for (treatment, label) combinations that do not occur naturally in the data.
Fixed ModuleNotFoundError: No module named 'sklearn.utils.testing'
Fixed ModuleNotFoundError: No module named 'sklearn.utils.testing'
paullo0106
requested changes
Jan 16, 2021
| @@ -191,7 +198,12 @@ def _GetNodeSummary(data, | |||
| for ti in treatment_group_keys: | |||
| results.update({ti: {}}) | |||
| for ci in y_name_keys: | |||
| results[ti].update({ci: results_series[ti, ci]}) | |||
| if smooth: | |||
| results[ti].update({ci: results[ti].update({ci: results_series[ti, ci] | |||
There was a problem hiding this comment.
Seems ci will all be None as dictionary updating method doesn't return any value, I don't think that's what you are trying to do here?
There was a problem hiding this comment.
Fixed. That was a clumsy copy-paste job that I overlooked somehow.
|
|
|
Currently the build is failing because shap is missing IPython as dependency. There is a PR related to fix this issue with Shap shap/shap#1749 |
paullo0106
approved these changes
Jan 20, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We get a KeyError issue in feature_selection/filters.py L197-203 when certain (treatment, y_label) combinations do not occur naturally in the dataset, e.g., if we never see label=1 for "treatment1".
Proposed changes
We can smooth label counts per treatment in _GetNodeSummary() by adding 1 for (treatment, label) combinations that do not occur naturally in the data. Issue opened @ #280
Types of changes
What types of changes does your code introduce to CausalML?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc. This PR template is adopted from appium.