Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an explicit treatment input argument to causaltree/forest #776

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

jeongyoonlee
Copy link
Collaborator

Proposed changes

This PR adds an explicit treatment input argument to CausalTreeRegressor.fit() and CausalRandomForestRegressor.fit().

Originally, it used sample_weight for treatment assignments to use the sklearn.tree APIs without modification, but, with #686, we don't use sklearn.tree anymore, and we're free to modify inputs to CausalTreeRegressor and CausalRandomForestRegressor.

All tests and notebook examples for causal tree/forest ran successfully without errors.

Types of changes

What types of changes does your code introduce to CausalML?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

This change will make it easy to add multiple treatment support to causal tree/forest (#775).

@CLAassistant
Copy link

CLAassistant commented May 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@ras44 ras44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only general comment is to perhaps consider a "major version" bump to 0.16 once this is merged given that the API has changed and treatment is now a required arg

@jeongyoonlee
Copy link
Collaborator Author

@alexander-pv, can you take a look at this PR before I merge it? Thanks in advance!

@jeongyoonlee jeongyoonlee merged commit b12c30b into master Jul 5, 2024
16 checks passed
@jeongyoonlee jeongyoonlee deleted the jeong/causaltree-multi-treatment branch October 4, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants