Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid assertion #39

Open
mattbasta opened this issue Jul 11, 2016 · 0 comments · May be fixed by #40
Open

Invalid assertion #39

mattbasta opened this issue Jul 11, 2016 · 0 comments · May be fixed by #40

Comments

@mattbasta
Copy link

Consider the following check:

https://github.com/uber/clay/blob/master/clay/database.py#L18

This line should be written as:

if dbapi_name not in ('psycopg2', 'MySQLdb', 'sqlite3'):

not dbapi_name will evaluate to a boolean, which will never be present in the tuple.
Qix- added a commit that referenced this issue Jul 11, 2016
@Qix-
Fix #39
f0d1152 
This fixes #39, since `not dbapi_name` will result in a boolean and then checked against an tuple.
@Qix- Qix- linked a pull request Jul 11, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #39 uber/clay
1 participant
@mattbasta