Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method name in documentation to match V4 name #192

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

ShaiDemri
Copy link
Contributor

The function name kRing is the name of a V3 function. I simply updated the documentation to the V4 name. gridDisk

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

@nrabinowitz
Copy link
Collaborator

Thanks! This actually requires rebuilding the documentation - I'll add another commit with that change.

@nrabinowitz
Copy link
Collaborator

Thanks! This actually requires rebuilding the documentation - I'll add another commit with that change.

Oh, sorry, I can't add commits to your PR. You can either:

  • Sign the CLA
  • Run build-docs and commit

or just let me know if you'd rather I make the change.

@ShaiDemri
Copy link
Contributor Author

Thanks! This actually requires rebuilding the documentation - I'll add another commit with that change.

Oh, sorry, I can't add commits to your PR. You can either:

  • Sign the CLA
  • Run build-docs and commit

or just let me know if you'd rather I make the change.

Done, let me know if there is anything else.

@ShaiDemri ShaiDemri requested a review from dfellis September 1, 2024 18:30
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10656367117

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.548%

Totals Coverage Status
Change from base Build 6669213392: 0.0%
Covered Lines: 549
Relevant Lines: 550

💛 - Coveralls

@nrabinowitz nrabinowitz merged commit 6978e9e into uber:master Sep 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants