Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Emscripten build in CI #6

Closed
wants to merge 1 commit into from

Conversation

isaacbrodsky
Copy link
Collaborator

Using the Docker images described in http://kripken.github.io/emscripten-site/docs/compiling/Travis.html

Fixes #5

@isaacbrodsky
Copy link
Collaborator Author

isaacbrodsky commented Jun 26, 2018

Unless Emscripten is being run at the wrong part of the build process, I'm not sure why this is failing. It is indeed running Emscripten, and apparently the right version, but it causes git diff to believe that the libh3.js file changes.

edit: after trying on another Linux system, it seems like maybe the artifact built on Linux is different than the artifact built on Mac OSX. Not sure how we want to handle that in CI.

@isaacbrodsky isaacbrodsky requested a review from nrabinowitz July 5, 2018 14:43
@nrabinowitz
Copy link
Collaborator

Hm. I'll need to look into this. One option is to change the build to always use a docker instance, even locally, which might be helpful for consistency (no longer relying on local env).

@nrabinowitz
Copy link
Collaborator

Closing, covered by #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants