Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump core library to 3.7.1, add support for cellArea, exactEdgeLength, pointDist #93

Merged
merged 6 commits into from
Oct 8, 2020
Merged

Bump core library to 3.7.1, add support for cellArea, exactEdgeLength, pointDist #93

merged 6 commits into from
Oct 8, 2020

Conversation

nrabinowitz
Copy link
Collaborator

  • Bumps core H3 library to 3.7.1
  • Adds support and tests for cellArea, exactEdgeLength, and pointDist functions

isaacbrodsky
isaacbrodsky reviewed Oct 8, 2020
View reviewed changes
lib/h3core.js Show resolved Hide resolved
lib/h3core.js Show resolved Hide resolved
nrabinowitz
nrabinowitz commented Oct 8, 2020
View reviewed changes
package.json
@@ -28,7 +28,7 @@
"scripts": {
"build-update-h3": "bash scripts/update-h3.sh",
"build-emscripten": "yarn build-update-h3 && yarn docker-emscripten",
"build-docs": "jsdoc2md --global-index-format grouped --partial doc-files/scope.hbs --helper ./doc-files/insert-version.js --separators --template doc-files/README.tmpl.md lib/h3core.js > README.md",
"build-docs": "jsdoc2md --no-cache --global-index-format grouped --partial doc-files/scope.hbs --helper ./doc-files/insert-version.js --separators --template doc-files/README.tmpl.md lib/h3core.js > README.md",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure that this + the JSDoc bump should fix problems in #91 - cc @isaacbrodsky

@coveralls
Copy link

Pull Request Test Coverage Report for Build 187

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 184: 0.0%
Covered Lines: 393
Relevant Lines: 393
💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 8, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 195

  • 30 of 30 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 193: 0.0%
Covered Lines: 393
Relevant Lines: 393
💛 - Coveralls

nrabinowitz
nrabinowitz commented Oct 8, 2020
View reviewed changes
test/h3core.spec.js
@@ -15,7 +15,7 @@
*/

import test from 'tape';
import * as h3core from '../lib/h3core.js';
import * as h3 from '../lib/h3core.js';
Copy link
Collaborator Author

@nrabinowitz nrabinowitz Oct 8, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduced a lot of noise into this file - the only new code here is the tests for the new functions.

dfellis
dfellis reviewed Oct 8, 2020
View reviewed changes
test/h3core.spec.js Outdated Show resolved Hide resolved
dfellis
dfellis reviewed Oct 8, 2020
View reviewed changes
test/h3core.spec.js Outdated Show resolved Hide resolved
@nrabinowitz nrabinowitz merged commit a75e346 into uber:master Oct 8, 2020
@nrabinowitz nrabinowitz deleted the bump-version branch October 8, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaacbrodsky isaacbrodsky isaacbrodsky left review comments

@dfellis dfellis dfellis approved these changes

@ajfriend ajfriend Awaiting requested review from ajfriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrabinowitz @coveralls @dfellis @isaacbrodsky