upgrade to h3 v4.2.0 #432
upgrade to h3 v4.2.0 #432
Conversation
src/h3/api/basic_int/__init__.py
Outdated
| flags : int | ||
| Containment mode flags |
There was a problem hiding this comment.
flags seems like it needs an enum
|
Coverage seems to be getting 403 which I don't think is related to this change. |
|
I was looking for docs on the containment modes and realized that we don't have it documented. As part of this effort, I think we should do: |
src/h3/api/basic_int/__init__.py
Outdated
| @@ -467,7 +467,7 @@ def uncompact_cells(cells, res): | |||
| return _out_collection(hu) | |||
|
|
|||
|
|
|||
| def h3shape_to_cells(h3shape, res): | |||
| def h3shape_to_cells(h3shape, res, flags=0, experimental=False): | |||
There was a problem hiding this comment.
I'm not sure if this should be the final form of the API. For example, we might not use integers for the flags, and we may drop the experimental option.
But it would be nice to get this functionality out so folks can start playing with it.
For the time being, could we leave h3shape_to_cells unchanged, and just create a h3shape_to_cells_experimental where we're free to change the API in the future?
|
This looks great. thanks! |
No description provided.