Add fuzzer for internal algos.c functions #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacbrodsky
force-pushed
the
fuzz-algos-internal
branch
from
1fe60c5 to
d85a9b2
Compare
isaacbrodsky
commented
Sep 6, 2022
Comment on lines
+40
to
+43
| for (size_t i = 0; i < expectedSize; i += sizeof(zero)) { | ||
| if (fwrite(&zero, sizeof(zero), 1, fp) != 1) { | ||
| error("Error writing\n"); | ||
| } |
There was a problem hiding this comment.
This was incorrectly reading garbage off the stack before.
Comment on lines
+66
to
+68
| if (!fp) { \ | ||
| error("Error opening test case file\n"); \ | ||
| } \ |
There was a problem hiding this comment.
This would unhelpfully segfault before.
nrabinowitz
approved these changes
Sep 6, 2022
dfellis
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to bring the fuzzer suite in uber/h3 to complete parity with what oss-fuzz is able to cover, since oss-fuzz also fuzzes the h3NeighborRotations internal function. Also I added a few advanced options which I hope will make oss-fuzz integration with the fuzzers here a little easier. google/oss-fuzz#8406