Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H3 CLI Region Subcommands #923

Merged
merged 16 commits into from
Oct 14, 2024
Merged

H3 CLI Region Subcommands #923

merged 16 commits into from
Oct 14, 2024

Commits on Oct 7, 2024

  1. H3 CLI Region Subcommands

    @dfellis
    dfellis committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    31be7ef View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
    @dfellis @isaacbrodsky
    dfellis and isaacbrodsky authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8a5fded View commit details
    Browse the repository at this point in the history

  3. Add multipolygon tests

    @dfellis
    dfellis committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7cb910f View commit details
    Browse the repository at this point in the history

  4. Improve polygon parsing across buffer length barrier

    @dfellis
    dfellis committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    24b0c6e View commit details
    Browse the repository at this point in the history

  5. Actually get polygon file reading working and add the polygon tests

    @dfellis
    dfellis committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    c994043 View commit details
    Browse the repository at this point in the history

  6. Fix compiler warning-as-error on Windows

    @dfellis
    dfellis committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    026e969 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. I totally get the memory leak pedantry for the library, but the CLI i… 

    …s just going to quit milliseconds after it's finished processing the data and printing to the screen, so it's kinda painful here.
    @dfellis
    dfellis committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8201d0f View commit details
    Browse the repository at this point in the history

  2. Update src/apps/filters/h3.c

    @dfellis
    dfellis authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0c4903b View commit details
    Browse the repository at this point in the history

  3. Update src/apps/filters/h3.c

    @dfellis
    dfellis authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4a8ca40 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. git clean -ffdx is my friend

    @dfellis
    dfellis committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0d6dc71 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
    @dfellis @isaacbrodsky
    dfellis and isaacbrodsky authored Oct 13, 2024
    Configuration menu
    Copy the full SHA
    6d2fab5 View commit details
    Browse the repository at this point in the history

  2. Fix formatting

    @dfellis
    dfellis committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    ad7dddc View commit details
    Browse the repository at this point in the history

  3. Abort polygon parsing early if we know the input is invalid

    @dfellis
    dfellis committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    d3a5a77 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
    @dfellis @isaacbrodsky
    dfellis and isaacbrodsky authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bcaac46 View commit details
    Browse the repository at this point in the history

  2. Update src/apps/filters/h3.c 

    Co-authored-by: Isaac Brodsky <isaac@isaacbrodsky.com>
    @dfellis @isaacbrodsky
    dfellis and isaacbrodsky authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8446f87 View commit details
    Browse the repository at this point in the history

  3. Address comments by @nrabinowitz

    @dfellis
    dfellis committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    03b8c97 View commit details
    Browse the repository at this point in the history