Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout threshold for fuzzer CI run #955

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

isaacbrodsky
Copy link
Collaborator

This is to avoid getting failures about the fuzzer timing out, which seems to happen since some cases may be slower than before. This is a bit inexact since perhaps there is some bad behavior with larger numbers of cells.

e.g. https://github.com/uber/h3/actions/runs/12289773577/job/34295819216?pr=953

@coveralls
Copy link

coveralls commented Dec 16, 2024

Coverage Status

coverage: 98.784%. remained the same
when pulling 7068ba0 on isaacbrodsky:reduce-fuzzer-max-experimental
into 18073a2 on uber:master.

@isaacbrodsky
Copy link
Collaborator Author

The original idea of reducing the fuzzer max size parameter didn't really work, so let's try increasing the timeout. OSS-Fuzz for comparison allows >= 1 hour before a timeout from what I see: https://github.com/search?q=repo%3Agoogle%2Foss-fuzz%20timeout&type=code

@isaacbrodsky isaacbrodsky changed the title Reduce maximum size for polygonToCellsExperimental fuzzers Increase timeout threshold for fuzzer CI run Dec 16, 2024
@isaacbrodsky isaacbrodsky merged commit ae31177 into uber:master Dec 23, 2024
38 checks passed
@isaacbrodsky isaacbrodsky deleted the reduce-fuzzer-max-experimental branch December 23, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants