Mark toolchains registered in our MODULE.bazel as a dev dependency #190
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzhp
approved these changes
Jul 11, 2024
|
@linzhp do you know why these tests all cancel after 11 minutes? |
|
It's probably due to a setting somewhere to cancel all remaining jobs if any job fails. In this case the macos-14 job failed |
jvolkman
force-pushed
the
dev/toolchain-dev-dep
branch
from
4db7571 to
b4cd017
Compare
jvolkman
force-pushed
the
dev/toolchain-dev-dep
branch
from
b4cd017 to
add1426
Compare
|
Hey @linzhp could you cut a release? Latest is May 13 and doesn't include this fix |
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark toolchains registered in this repo as a dev dependency. Users will need to register their own toolchains, like they do in WORKSPACE.
Fixes #181.